Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: CNV-38502: Allow changing CPU and memory when Dedicated resources is enabled #2003

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pcbailey
Copy link
Member

@pcbailey pcbailey commented Jun 5, 2024

📝 Description

This PR fixes a bug that prevents the user from changing the memory of a VM that has "Dedicated resources" enabled.

Jira: https://issues.redhat.com/browse/CNV-38502

🎥 Demo

Before

After

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 5, 2024

@pcbailey: This pull request references CNV-38502 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

📝 Description

This PR fixes a bug that prevents the user from changing the memory of a VM that has "Dedicated resources" enabled.

Jira: https://issues.redhat.com/browse/CNV-38502

🎥 Demo

Before

After

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from hstastna and metalice June 5, 2024 15:21
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 5, 2024
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Aug 18, 2024
Copy link
Contributor

openshift-ci bot commented Aug 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix do-not-merge/work-in-progress jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants