Merge pull request #13 from mhenriks/perishable-api-change

change signature of perishables callback to include the CR and logger
kubevirt · Dec 16, 2020 · 30accfa · 30accfa
2 parents d6d15f4 + 5f91c31
commit 30accfa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/sdk/reconciler/builder.go b/pkg/sdk/reconciler/builder.go
@@ -103,6 +103,6 @@ func updateControllerConfiguration(_ controllerutil.Object) error {
 	return nil
 }
 
-func syncPerishables() error {
+func syncPerishables(cr controllerutil.Object, logger logr.Logger) error {
 	return nil
 }
diff --git a/pkg/sdk/reconciler/reconciler.go b/pkg/sdk/reconciler/reconciler.go
@@ -45,7 +45,7 @@ const (
 )
 
 // PerishablesSynchronizer is expected to execute perishable resources (i.e. certificates) synchronization if required
-type PerishablesSynchronizer func() error
+type PerishablesSynchronizer func(cr controllerutil.Object, logger logr.Logger) error
 
 // ControllerConfigUpdater is expected to update controller configuration if required
 type ControllerConfigUpdater func(cr controllerutil.Object) error
@@ -322,7 +322,7 @@ func (r *Reconciler) ReconcileUpdate(logger logr.Logger, cr controllerutil.Objec
 		}
 	}
 
-	if err = r.syncPerishables(); err != nil {
+	if err = r.syncPerishables(cr, logger); err != nil {
 		return reconcile.Result{}, err
 	}