Skip observability controller tests if no SA TLS cert

controllers/observability/pod_disruption_budget_at_limit.go

@@ -12,8 +12,11 @@ import (
 )
 
 const (
+	// ServiceAccountTlsCertPath is the path to the service account TLS certificate
+	// used for TLS communication with the alertmanager API
+	ServiceAccountTlsCertPath = "/var/run/secrets/kubernetes.io/serviceaccount/service-ca.crt"
+
 	alertmanagerSvcHost = "https://alertmanager-main.openshift-monitoring.svc.cluster.local:9094"
-	tlsCertPath         = "/var/run/secrets/kubernetes.io/serviceaccount/service-ca.crt"
 )
 
 func (r *Reconciler) ensurePodDisruptionBudgetAtLimitIsSilenced() error {
@@ -64,7 +67,7 @@ func (r *Reconciler) ensurePodDisruptionBudgetAtLimitIsSilenced() error {
 }
 
 func (r *Reconciler) NewAlertmanagerApi() (*alertmanager.Api, error) {
-	caCert, err := os.ReadFile(tlsCertPath)
+	caCert, err := os.ReadFile(ServiceAccountTlsCertPath)
 	if err != nil {
 		return nil, fmt.Errorf("failed to read ca cert: %w", err)
 	}

tests/func-tests/observability_controller_test.go

@@ -2,6 +2,8 @@ package tests_test
 
 import (
 	"context"
+	"errors"
+	"os"
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
@@ -13,8 +15,22 @@ import (
 	tests "github.com/kubevirt/hyperconverged-cluster-operator/tests/func-tests"
 )
 
-var _ = Describe("Observability Controller", Label(tests.OpenshiftLabel, "observability_controller"), func() {
+const testName = "observability_controller"
+
+var _ = Describe("Observability Controller", Label(tests.OpenshiftLabel, testName), func() {
 	Context("PodDisruptionBudgetAtLimit", func() {
+		BeforeEach(func(ctx context.Context) {
+			cli := tests.GetControllerRuntimeClient()
+			tests.FailIfNotOpenShift(ctx, cli, testName)
+
+			certExists, err := serviceAccountTlsCertPathExists()
+			Expect(err).ToNot(HaveOccurred())
+
+			if !certExists {
+				Fail("Service account TLS certificate path does not exist")
+			}
+		})
+
 		It("should be silenced", func() {
 			r := observability.NewReconciler(tests.GetClientConfig())
 
@@ -55,3 +71,15 @@ var _ = Describe("Observability Controller", Label(tests.OpenshiftLabel, "observ
 		})
 	})
 })
+
+func serviceAccountTlsCertPathExists() (bool, error) {
+	_, err := os.Stat(observability.ServiceAccountTlsCertPath)
+	if errors.Is(err, os.ErrNotExist) {
+		return false, nil
+	}
+	if err != nil {
+		return false, err
+	}
+
+	return true, nil
+}