Test and env updates #208
Test and env updates #208
Conversation
kubevirt-bot
added
the
dco-signoff: yes
This label can be used to run tests with focus on tests we consider neccessary to test partner compatibility with kubevirt. To run the tests: make TEST_ARGS="--test-args=-ginkgo.label-filter=PartnerComp" test-functional Signed-off-by: Shelly Kagan <[email protected]>
ShellyKa13
force-pushed
the
test-and-env-updates
branch
from
172ebaf to
9220bba
Compare
velero-v1.12.0-linux-amd64/LICENSE
Outdated
| @@ -0,0 +1,201 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
this was done automatically when running the update kubevirtci script..
There was a problem hiding this comment.
Yeah at some point velero is downloaded but I don't think we want to add it to the repo. Maybe put something in gitignore?
There was a problem hiding this comment.
@mhenriks add the gitignore and deleted an existing velero repo we had in here.
|
@ShellyKa13 Can you edit the PR description to briefly state reasoning for changes to to tests/manifests? |
This change allows the user to set env variable KVP_STORAGE_CLASS with the desired storage class one wants the tests applying yamls to run with. Adjust some tests to pass when using wffc SC Signed-off-by: Shelly Kagan <[email protected]>
The test wants to catch the dv in state importing but if the import is fast we can miss it. Insted we can check that a file that existed no longer exists after the backup. Signed-off-by: Shelly Kagan <[email protected]>
Signed-off-by: Shelly Kagan <[email protected]>
ShellyKa13
force-pushed
the
test-and-env-updates
branch
2 times, most recently
from
d171a45 to
39c8ad9
Compare
Signed-off-by: Shelly Kagan <[email protected]>
ShellyKa13
force-pushed
the
test-and-env-updates
branch
from
39c8ad9 to
4fa6d8b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/cherrypick release-0.6 |
|
@ShellyKa13: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-v0.6 |
|
@ShellyKa13: new pull request created: #220 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This change is a first step in trying to make our tests usable to test compatibility with kubevirt for other backup partners.
This change marks tests that apply example manifests with label
PartnerComp. This allows to run only those tests with gingko filter:make TEST_ARGS="--test-args=-ginkgo.label-filter=PartnerComp" test-functional
Also those yamls were hardcoded with a storageclass, now changed the framework in order to make it possible to config other SC by updating env variable KVP_STORAGE_CLASS
To apply the yamls manually you'll need to replace the placeholder {{KVP_STORAGE_CLASS}} with your desired storageclass or run it with a replace command such as:
cat tests/manifests/vm_with_pvc.yaml | sed 's/{{KVP_STORAGE_CLASS}}/rook-ceph-block/g' | kubectl create -f -
Updated kubevirtci due to a bug in the last version of a problem running with docker.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: