Fix test issues + increase number of nodes in the cluster #241

ShellyKa13 · 2024-04-17T12:02:47Z

What this PR does / why we need it:
We have seen several test issues when running with more then 1 nodes.
This PR fixes those issues and increase the number of nodes running in the CI to better catch this issues.
Changes:

Fixed pod security and arranged pod related functionallities (should solve failures in test 9864)
Fixed issue in test 10191. jira-ticket: https://issues.redhat.com/browse/CNV-39913
Remove debug code that causes timeouts d/s when the test fails there.
Update instancetype and preferences manifests version since alpha is deprecated and will be removed soon

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # test 9864 and 10191 d/s

Special notes for your reviewer:

Release note:

Create cluster with 2 nodes

mhenriks · 2024-04-18T20:17:30Z

/lgtm
/approve

ShellyKa13 · 2024-04-21T14:10:31Z

/hold
Changed number of nodes in the cluster, I want to run several times to see its stable

awels

I know you mostly just moved some stuff around, but since you are improving the code maybe look at some of the nits. I am fine if you ignore me.

awels · 2024-04-25T14:06:14Z

tests/framework/pod.go

+		},
+		Spec: v1.PodSpec{
+			SecurityContext: &v1.PodSecurityContext{
+				FSGroup: pointer.Int64(uid),


I think the pointer library is deprecated and you should use the ptr library k8s.io/utils/ptr. This becomes something like this

ptr.To[int64](uid)

awels · 2024-04-25T14:09:54Z

tests/framework/pod.go

+						},
+					},
+					SecurityContext: &v1.SecurityContext{
+						RunAsNonRoot: pointer.Bool(true),


same with pointer to ptr

RunAsNonRoot : ptr.To[bool](true)

tests/framework/pod.go

…d of alpha Signed-off-by: Shelly Kagan <[email protected]>

First write to the pvc and only after start the vm, this will prevent the option of pvc already mounted to the virt-launcher and then the writer-pod might fail writing from another pod it will be scheduled on. Also delete redundant stop of vm before deletion. Fixes: https://issues.redhat.com/browse/CNV-39913 Signed-off-by: Shelly Kagan <[email protected]>

*Remove duplicated function (NewPod) *Fix pod security issues by using function that already handles that *Move pod functions to new file *Create and use wait for pod phase function Signed-off-by: Shelly Kagan <[email protected]>

Signed-off-by: Shelly Kagan <[email protected]>

awels

/approve

kubevirt-bot · 2024-04-30T15:35:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels, mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [awels,mhenriks]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ShellyKa13 · 2024-04-30T15:35:59Z

/unhold

ShellyKa13 · 2024-05-01T07:12:58Z

/cherrypick release-v0.6

kubevirt-bot · 2024-05-01T07:13:42Z

@ShellyKa13: #241 failed to apply on top of branch "release-v0.6":

Applying: Update version of instancetype and prefernce yamls to use beta instead of alpha
Applying: Move start of vm to after writer pod succeeded
Applying: Gather all pod related functions in one place
Using index info to reconstruct a base tree...
M	tests/framework/storage.go
M	tests/resource_filtering_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/resource_filtering_test.go
Auto-merging tests/framework/storage.go
CONFLICT (content): Merge conflict in tests/framework/storage.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Gather all pod related functions in one place
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 17, 2024

kubevirt-bot requested review from awels and mhenriks April 17, 2024 12:02

ShellyKa13 removed the request for review from awels April 17, 2024 12:02

kubevirt-bot added the size/S label Apr 17, 2024

kubevirt-bot assigned mhenriks Apr 18, 2024

kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 18, 2024

ShellyKa13 force-pushed the fix-pod-security branch from 6718716 to 7545885 Compare April 21, 2024 14:09

kubevirt-bot added size/L and removed lgtm Indicates that a PR is ready to be merged. size/S labels Apr 21, 2024

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2024

ShellyKa13 changed the title ~~Fix test pod security + Update version of instancetype and prefernce yamls~~ Fix test issues + increase number of nodes in the cluster Apr 21, 2024

ShellyKa13 force-pushed the fix-pod-security branch from 7545885 to ea8a9f6 Compare April 21, 2024 15:16

awels reviewed Apr 25, 2024

View reviewed changes

kubevirt-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL and removed size/L labels Apr 30, 2024

ShellyKa13 added 6 commits April 30, 2024 16:43

Update version of instancetype and prefernce yamls to use beta instea…

3e8034f

…d of alpha Signed-off-by: Shelly Kagan <[email protected]>

Gather all pod related functions in one place

38feab1

*Remove duplicated function (NewPod) *Fix pod security issues by using function that already handles that *Move pod functions to new file *Create and use wait for pod phase function Signed-off-by: Shelly Kagan <[email protected]>

Remove debug code

af30cfb

Signed-off-by: Shelly Kagan <[email protected]>

Change cluster to have default 2 nodes

e57280f

Signed-off-by: Shelly Kagan <[email protected]>

Replace deprecated pointer with ptr package

26fb1a3

Signed-off-by: Shelly Kagan <[email protected]>

ShellyKa13 force-pushed the fix-pod-security branch from 9bc8fc5 to 26fb1a3 Compare April 30, 2024 13:45

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024

awels approved these changes Apr 30, 2024

View reviewed changes

kubevirt-bot assigned awels Apr 30, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2024

kubevirt-bot merged commit 2c6758b into kubevirt:main Apr 30, 2024
5 checks passed

ShellyKa13 mentioned this pull request May 1, 2024

[release-v0.6] Fix test issues + increase number of nodes in the cluster #246

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix test issues + increase number of nodes in the cluster #241

Fix test issues + increase number of nodes in the cluster #241

ShellyKa13 commented Apr 17, 2024 •

edited

Loading

mhenriks commented Apr 18, 2024

ShellyKa13 commented Apr 21, 2024

awels left a comment

awels Apr 25, 2024

ShellyKa13 Apr 30, 2024

awels Apr 25, 2024

ShellyKa13 Apr 30, 2024

awels left a comment

kubevirt-bot commented Apr 30, 2024

ShellyKa13 commented Apr 30, 2024

ShellyKa13 commented May 1, 2024

kubevirt-bot commented May 1, 2024

Fix test issues + increase number of nodes in the cluster #241

Fix test issues + increase number of nodes in the cluster #241

Conversation

ShellyKa13 commented Apr 17, 2024 • edited Loading

mhenriks commented Apr 18, 2024

ShellyKa13 commented Apr 21, 2024

awels left a comment

Choose a reason for hiding this comment

awels Apr 25, 2024

Choose a reason for hiding this comment

ShellyKa13 Apr 30, 2024

Choose a reason for hiding this comment

awels Apr 25, 2024

Choose a reason for hiding this comment

ShellyKa13 Apr 30, 2024

Choose a reason for hiding this comment

awels left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Apr 30, 2024

ShellyKa13 commented Apr 30, 2024

ShellyKa13 commented May 1, 2024

kubevirt-bot commented May 1, 2024

ShellyKa13 commented Apr 17, 2024 •

edited

Loading