Add functest coverage for MetadataBackupLabel #291
Conversation
Signed-off-by: Alvaro Romero <[email protected]>
kubevirt-bot
added
dco-signoff: yes
There was a problem hiding this comment.
looks good! small comment.
I think it will be cool if we will change the framework of creating a backup to be similar to how a vm is being created in kubevirt example: https://github.com/kubevirt/kubevirt/blob/main/tests/vm_test.go#L101
But this is a future thinking irrelevant to this PR :)
| args := []string{ | ||
| "create", "backup", backupName, | ||
| "--include-namespaces", namespace, | ||
| "--include-namespaces", includedNamespace, |
There was a problem hiding this comment.
I see that currently the use of this function always provides includedNamespace but if you made it generic maybe you should treat it the same as the other variable with if includedNamespace != ""
|
Pull requests that are marked with After that period the bot marks them with the label /label needs-approver-review |
kubevirt-bot
added
the
needs-approver-review
|
taking the liberty to also approve this to get this test change in |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ShellyKa13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
/remove-label needs-approver-review |
kubevirt-bot
removed
the
needs-approver-review
What this PR does / why we need it:
This PR adds a new functional test to cover the MetadataBackupLabel feature.
It also refactors some test helpers to avoid code repetition.
Release note: