-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s-provider: Remove KUBEVIRT_CPU_MANAGER_POLICY #1289
k8s-provider: Remove KUBEVIRT_CPU_MANAGER_POLICY #1289
Conversation
Skipping CI for Draft Pull Request. |
1c23f2a
to
fb2a713
Compare
Signed-off-by: Lee Yarwood <[email protected]>
Feature Default Stage Since Until --------------------------------------------- CPUManager false Alpha 1.8 1.9 CPUManager true Beta 1.10 1.25 CPUManager true GA 1.26 – https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-graduated-or-deprecated-features Signed-off-by: Lee Yarwood <[email protected]>
fb2a713
to
37ab844
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
thanks @lyarwood for cleaning this up!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest-required |
@lyarwood: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
[997cbff k8s-provider: Remove KUBEVIRT_CPU_MANAGER_POLICY](kubevirt/kubevirtci#1289) [c2e547b fix: gocli startup in s390x architecture](kubevirt/kubevirtci#1354) [1e31064 cluster-up, kind, common: Enable TopologyManager for kind-sriov](kubevirt/kubevirtci#1347) [00a9d12 Kubelet drop in](kubevirt/kubevirtci#1299) [6b7d14b build(deps): bump golang.org/x/net in /cluster-provision/gocli](kubevirt/kubevirtci#1364) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
Thanks |
[997cbff k8s-provider: Remove KUBEVIRT_CPU_MANAGER_POLICY](kubevirt/kubevirtci#1289) [c2e547b fix: gocli startup in s390x architecture](kubevirt/kubevirtci#1354) [1e31064 cluster-up, kind, common: Enable TopologyManager for kind-sriov](kubevirt/kubevirtci#1347) [00a9d12 Kubelet drop in](kubevirt/kubevirtci#1299) [6b7d14b build(deps): bump golang.org/x/net in /cluster-provision/gocli](kubevirt/kubevirtci#1364) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
[997cbff k8s-provider: Remove KUBEVIRT_CPU_MANAGER_POLICY](kubevirt/kubevirtci#1289) [c2e547b fix: gocli startup in s390x architecture](kubevirt/kubevirtci#1354) [1e31064 cluster-up, kind, common: Enable TopologyManager for kind-sriov](kubevirt/kubevirtci#1347) [00a9d12 Kubelet drop in](kubevirt/kubevirtci#1299) [6b7d14b build(deps): bump golang.org/x/net in /cluster-provision/gocli](kubevirt/kubevirtci#1364) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: