Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split Policy interface and create PolicyGroup interface #886

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

fabriziosestito
Copy link
Contributor

Description

Fixes: #842

@fabriziosestito fabriziosestito requested a review from a team as a code owner September 19, 2024 08:22
@fabriziosestito fabriziosestito self-assigned this Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (8237b77) to head (9b2cabd).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
api/policies/v1/policygroup_validation.go 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
+ Coverage   70.40%   70.51%   +0.10%     
==========================================
  Files          30       30              
  Lines        2619     2601      -18     
==========================================
- Hits         1844     1834      -10     
+ Misses        602      594       -8     
  Partials      173      173              
Flag Coverage Δ
integration-tests 60.45% <26.08%> (+0.03%) ⬆️
unit-tests 39.21% <94.11%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flavio
Copy link
Member

flavio commented Sep 19, 2024

nice refactor!

@flavio flavio merged commit d0e5c14 into kubewarden:main Sep 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Refactor policy interface
2 participants