ci: Ensure SLSA Lvl 3 #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
- Coverage 70.65% 68.97% -1.69%
==========================================
Files 30 30
Lines 2559 3052 +493
==========================================
+ Hits 1808 2105 +297
- Misses 582 777 +195
- Partials 169 170 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
viccuad
force-pushed
the
slsa
branch
6 times, most recently
from
30fba55 to
6066471
Compare
jvanz
reviewed
Oct 8, 2024
jvanz
reviewed
Oct 8, 2024
pjbgf
reviewed
Oct 8, 2024
viccuad
force-pushed
the
slsa
branch
2 times, most recently
from
efac9fe to
fe1f8c1
Compare
jhkrug
suggested changes
Oct 9, 2024
|
Applied suggestions and rebased, as it was easier to keep the Co-authored-by. Sorry for the inconvenience. |
jvanz
requested changes
Oct 11, 2024
viccuad
force-pushed
the
slsa
branch
3 times, most recently
from
c79fc29 to
08758a8
Compare
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]> Co-authored-by: José Guilherme Vanz <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]> Co-authored-by: José Guilherme Vanz <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]> Co-authored-by: José Guilherme Vanz <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Co-authored-by: John Krug <[email protected]> Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
We are not making use of a regexp anymore and provide fully qualified identities. Signed-off-by: Víctor Cuadrado Juan <[email protected]>
|
Rebased onto main to fix conflicts. |
pjbgf
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #898.
Adapted the work already done by @jvanz from kubewarden/audit-scanner#387 (hence, set @jvanz as Co-authored-by).
Test
Tested by tagging on my fork as
v1.18.0-viccuad.See:
https://github.com/viccuad/kubewarden-controller/actions/runs/11403999799 (release only fails in the last bot pr step)
https://github.com/viccuad/kubewarden-controller/releases/tag/v1.18.0-viccuad9
Additional Information
Tradeoff
Potential improvement