Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): empty cpuset.mems will lead to failure of tmo #721

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 59.67742% with 25 lines in your changes missing coverage. Please review.

Project coverage is 55.88%. Comparing base (19aa317) to head (c909ef8).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/util/cgroup/manager/cgroup.go 55.26% 12 Missing and 5 partials ⚠️
pkg/util/cgroup/manager/v1/fs_linux.go 66.66% 2 Missing and 1 partial ⚠️
pkg/util/cgroup/manager/v2/fs_linux.go 66.66% 2 Missing and 1 partial ⚠️
...ins/memory/dynamicpolicy/policy_advisor_handler.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
- Coverage   56.04%   55.88%   -0.16%     
==========================================
  Files         594      597       +3     
  Lines       67830    68011     +181     
==========================================
- Hits        38012    38009       -3     
- Misses      25771    25955     +184     
  Partials     4047     4047              
Flag Coverage Δ
unittest 55.88% <59.67%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin force-pushed the fix/tmo branch 19 times, most recently from 587e054 to 30f7cc6 Compare November 16, 2024 14:51
@cheney-lin cheney-lin self-assigned this Nov 17, 2024
@cheney-lin cheney-lin added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Nov 17, 2024
@yadzhang
Copy link
Collaborator

LGTM

@xu282934741 xu282934741 merged commit 7f6d067 into kubewharf:main Nov 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants