Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kcc): support kcc canary update #722

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gary-lgy
Copy link
Member

What type of PR is this?

Features

What this PR does / why we need it:

Support canary update for KCC targets.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@gary-lgy gary-lgy changed the title chore(dep): update katalyst-api feat(kcc): support kcc canary update Nov 14, 2024
@gary-lgy gary-lgy requested a review from caohe as a code owner November 14, 2024 11:27
@gary-lgy gary-lgy force-pushed the kcc-canary branch 2 times, most recently from 4f776bc to e658780 Compare November 14, 2024 12:50
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 68.57749% with 148 lines in your changes missing coverage. Please review.

Project coverage is 55.98%. Comparing base (3269ac6) to head (3ad9448).

Files with missing lines Patch % Lines
pkg/controller/kcc/kcct.go 67.28% 110 Missing and 31 partials ⚠️
pkg/controller/kcc/util/kcct.go 85.18% 3 Missing and 1 partial ⚠️
pkg/controller/kcc/kcc.go 0.00% 1 Missing ⚠️
pkg/controller/kcc/target/target_handler.go 0.00% 1 Missing ⚠️
pkg/metaserver/kcc/manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
+ Coverage   55.80%   55.98%   +0.18%     
==========================================
  Files         594      593       -1     
  Lines       67830    67819      -11     
==========================================
+ Hits        37850    37968     +118     
+ Misses      25956    25846     -110     
+ Partials     4024     4005      -19     
Flag Coverage Δ
unittest 55.98% <68.57%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gary-lgy gary-lgy force-pushed the kcc-canary branch 2 times, most recently from 3ad9448 to 0e4660a Compare November 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant