Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify the ObjectRef and GroupingKey types #158

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Aug 16, 2023

Description

Related issues

Special notes for your reviewer:

@SOF3 SOF3 requested a review from xuqingyun August 16, 2023 04:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Patch coverage: 6.45% and project coverage change: -0.81% ⚠️

Comparison is base (f511c44) 37.63% compared to head (880213c) 36.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   37.63%   36.82%   -0.81%     
==========================================
  Files          32       33       +1     
  Lines        2559     2626      +67     
==========================================
+ Hits          963      967       +4     
- Misses       1533     1596      +63     
  Partials       63       63              
Files Changed Coverage Δ
pkg/diff/cache/interface.go 11.26% <0.00%> (ø)
pkg/diff/cache/memory_wrapper.go 0.00% <0.00%> (ø)
pkg/util/object/rich.go 0.00% <0.00%> (ø)
pkg/util/object/key.go 5.00% <5.00%> (ø)
pkg/k8s/objectcache/objectcache.go 51.35% <80.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuqingyun xuqingyun merged commit eb6ec46 into kubewharf:main Aug 30, 2023
9 checks passed
@SOF3 SOF3 deleted the unify-object-ref branch August 30, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants