refactor: remove redundant returned error #290
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 33.28% 31.49% -1.79%
==========================================
Files 155 122 -33
Lines 17892 14300 -3592
==========================================
- Hits 5955 4504 -1451
+ Misses 11427 9391 -2036
+ Partials 510 405 -105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
z1cheng
force-pushed
the
refactor_annotation
branch
6 times, most recently
from
2b1b473
to
a162cdf
Compare
z1cheng
changed the title
pkg/util/annotation/annotation.go
Outdated
| @@ -30,81 +29,71 @@ const ( | |||
| ) | |||
|
|
|||
| // HasAnnotationKey returns true if the given object has the given annotation key in its ObjectMeta. | |||
| func HasAnnotationKey(obj metav1.Object, key string) (bool, error) { | |||
| func HasAnnotationKey(obj metav1.Object, key string) bool { | |||
| if IsNilPointer(obj) { | |||
There was a problem hiding this comment.
Let's remove this IsNilPointer check to expose the problem early.
There was a problem hiding this comment.
Let's try removing IsNilPointer check from all the functions in this file. If there's no other references to IsNilReference, we should remove its definition as well.
pkg/util/annotation/annotation.go
Outdated
| if key == "" { | ||
| return false, fmt.Errorf("key is a empty string.") | ||
| func AddAnnotation(obj metav1.Object, key, value string) bool { | ||
| if IsNilPointer(obj) || key == "" { |
There was a problem hiding this comment.
The key is usually a constant, so the chance that it's empty is slim. Let's remove this key check to make it clear that it's the caller's responsibility to pass in a valid key.
There was a problem hiding this comment.
Pls fix the unit tests. I think we can remove the test cases where an empty key is passed in.
z1cheng
force-pushed
the
refactor_annotation
branch
2 times, most recently
from
019dafe
to
24ce9e4
Compare
z1cheng
force-pushed
the
refactor_annotation
branch
3 times, most recently
from
5cbf6bc
to
53df1bc
Compare
Signed-off-by: z1cheng <[email protected]>
z1cheng
force-pushed
the
refactor_annotation
branch
from
53df1bc
to
612b1aa
Compare
close #99