Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove includes config from globals #99

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Remove includes config from globals #99

merged 2 commits into from
Jun 26, 2024

Conversation

Bernix01
Copy link
Contributor

This changes fixes #98

@Bernix01 Bernix01 changed the title Remove includes config from gloabals #98 Remove includes config from gloabals Jun 24, 2024
@kucrut kucrut changed the title Remove includes config from gloabals Remove includes config from globals Jun 26, 2024
Copy link
Owner

@kucrut kucrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Bernix01. Just a minor coding style issue need to be fixed and I'll merge this right away as I just encountered this bug myself 😉

src/exports/plugins/wp-scripts.js Outdated Show resolved Hide resolved
@kucrut kucrut merged commit 2af141c into kucrut:main Jun 26, 2024
2 checks passed
kucrut added a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

globals config not working with dependencies
2 participants