Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis integration #108

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add travis integration #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82d4b4d
Add travis support for smart-app-banner (it's about time)
GabLeRoux Jul 27, 2018
16e09f7
Add eslint dev dependency
GabLeRoux Jul 27, 2018
b322b66
Add eslint to dev commands
GabLeRoux Jul 27, 2018
daebbb0
Fix linter error (used automatic fix from eslint)
GabLeRoux Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
language: node_js
node_js:
- "node"
- "lts/*"
- "8"
- "7"
- "6"
script:
- npm run build
- npm run lint

2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ The following commands are available for compiling the project:
| ------- | ------ |
| `npm install` | Installs the required dependencies |
| `npm run build` | Builds the application JavaScript. |
| `npm run lint` | Check for linter error. |
| `npm run eslint -- --fix index.js` | Fix linter error automatically. |

## See also

Expand Down
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ var mixins = {
appMeta: 'apple-itunes-app',
iconRels: ['apple-touch-icon-precomposed', 'apple-touch-icon'],
getStoreLink: function () {
return 'https://itunes.apple.com/' + this.options.appStoreLanguage + '/app/id' + this.appId + "?mt=8";
return 'https://itunes.apple.com/' + this.options.appStoreLanguage + '/app/id' + this.appId + '?mt=8';
}
},
android: {
Expand Down
6 changes: 4 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"main": "index.js",
"scripts": {
"build": "browserify index.js -s SmartBanner | ccjs - > dist/smart-app-banner.js",
"lint": "eslint index.js"
"lint": "eslint index.js",
"eslint": "eslint"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -45,6 +46,7 @@
},
"devDependencies": {
"browserify": "^16.2.2",
"closurecompiler": "^1.6.1"
"closurecompiler": "^1.6.1",
"eslint": "^5.2.0"
}
}