bug fix #96
Open
bug fix #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabLeRoux
reviewed
Nov 29, 2017
There was a problem hiding this comment.
Before this change, it was hiding the banner only when on Safari IOS without appId.
Now it would hide if there's no appId and would also hide if on safari ios.
I think it makes sens:
- When there's no app id, nothing should be shown.
- When on ios safari, nothing should be shown. (On safari, it will show native banner)
I think there should be a configuration here to allow displaying it on ios as some people don't use the native one. (I'm in that case and it works by coincidence based on your fix) 👍
|
Yes, I have just implemented the test as the comments it shoud do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the test was not done well