Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link. #1068

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Fix broken link. #1068

merged 1 commit into from
Nov 18, 2019

Conversation

mpereira
Copy link
Member

No description provided.

alenkacz
alenkacz approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@mpereira mpereira merged commit a68eb29 into master Nov 18, 2019
@mpereira mpereira deleted the fix-broken-link branch November 18, 2019 12:49
@porridge
Copy link
Member

porridge commented Nov 21, 2019 •
edited
Loading

I don't get it, what is broken about the original v2 link that I set this to in #1048?

@mpereira you seem to have changed to link to kubebuilder v1 docs, while @alenkacz who approved this specifically said that we wanted v2. (And which seems to match the code).

@alenkacz
Copy link
Contributor

@porridge wait I thought v1 is never :D because it looks better. But they also link to http://book.kubebuilder.io on the official repo. Should we revert then?

@mpereira
Copy link
Member Author

@porridge the https://book.kubebuilder.io/quick-start.html#installation URL was broken at the time this PR was opened.

porridge added a commit that referenced this pull request Nov 21, 2019
@porridge
Revert "Fix broken link. (#1068)"
497beb3 
This reverts commit a68eb29.
@porridge porridge mentioned this pull request Nov 21, 2019
Merged
@porridge
Copy link
Member

Funny, since I had just changed to that from another broken link a couple of days before your PR. But it's back, so let's revert.

@mpereira
Copy link
Member Author

Created:

alenkacz pushed a commit that referenced this pull request Nov 21, 2019
@porridge @alenkacz
Revert "Fix broken link. (#1068)" (#1093)
3ccc31d 
This reverts commit a68eb29.
@porridge porridge mentioned this pull request Nov 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenkacz alenkacz alenkacz approved these changes

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

@zen-dog zen-dog Awaiting requested review from zen-dog zen-dog is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpereira @porridge @alenkacz