Apply suggestions from code review

kudobuilder · Aug 22, 2024 · 832d572 · 832d572
1 parent add5d67
commit 832d572
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/docs/cli.md b/docs/cli.md
@@ -61,7 +61,7 @@ Flags are:
 
   Directory to output kind logs to (if not specified, the current working directory).
 
-* **`--as`**
+* **`--as (string)`**
 
   The kubernetes user to impersonate for the operation. User could be a regular user or a service account in a namespace.
 

diff --git a/pkg/k8s/main.go b/pkg/k8s/main.go
@@ -9,9 +9,8 @@ var ImpersonateAs = ""
 
 func GetConfig() (*rest.Config, error) {
 	cfg, err := config.GetConfig()
-
 	if err != nil {
-		return &rest.Config{}, err
+		return nil, err
 	}
 
 	if ImpersonateAs != "" {

diff --git a/pkg/test/assert.go b/pkg/test/assert.go
@@ -106,15 +106,13 @@ func Errors(namespace string, timeout int, errorFiles ...string) error {
 
 func Client(_ bool) (client.Client, error) {
 	cfg, err := k8s.GetConfig()
-
 	if err != nil {
 		return nil, err
 	}
 
 	client, err := testutils.NewRetryClient(cfg, client.Options{
 		Scheme: testutils.Scheme(),
 	})
-
 	if err != nil {
 		return nil, fmt.Errorf("fatal error getting client: %v", err)
 	}
@@ -124,13 +122,11 @@ func Client(_ bool) (client.Client, error) {
 
 func DiscoveryClient() (discovery.DiscoveryInterface, error) {
 	cfg, err := k8s.GetConfig()
-
 	if err != nil {
 		return nil, err
 	}
 
 	dclient, err := discovery.NewDiscoveryClientForConfig(cfg)
-
 	if err != nil {
 		return nil, fmt.Errorf("fatal error getting discovery client: %v", err)
 	}