fix: handle redundant deletion of Namespace #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar-mallikarjuna
requested review from
kensipe and
porridge
as code owners
porridge
approved these changes
Sep 19, 2024
|
Sorry, I made a mess with the sign-off again 🤦🏻 |
|
Hey @porridge , might need to fix your sign-off here 😅 |
Yes, but unfortunately I'm not able to do it myself. GitHub allows me to push a commit to your repo's branch based on a review suggestion (which is what I did, but used the wrong email) but it will not allow me to rewrite that commit. Sorry but I'll have to ask you to squash that commit into yours. |
Signed-off-by: Kumar Mallikarjuna <[email protected]>
kumar-mallikarjuna
force-pushed
the
fix-565
branch
from
08fe94c
to
1423fa7
Compare
|
Done, @porridge . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an
IsNotFoundcheck before attempting to delete theCase's Namespace.Fixes #565