-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Expression-Based Assertions KEP #568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar-mallikarjuna
requested review from
kensipe and
porridge
as code owners
September 23, 2024 13:02
kumar-mallikarjuna
force-pushed
the
kep-cel
branch
from
September 23, 2024 15:23
3aab73f
to
63d80ac
Compare
eddycharly
reviewed
Sep 24, 2024
eddycharly
reviewed
Sep 24, 2024
kumar-mallikarjuna
force-pushed
the
kep-cel
branch
from
September 24, 2024 12:37
13c543f
to
c6a8c0e
Compare
porridge
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some more suggestions inline.
kumar-mallikarjuna
changed the title
chore: add CEL Assertions KEP
chore: add Expression-Based Assertions KEP
Oct 14, 2024
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
Signed-off-by: Kumar Mallikarjuna <[email protected]>
kumar-mallikarjuna
force-pushed
the
kep-cel
branch
from
October 14, 2024 17:39
e17e19c
to
de4c229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a KEP for #562.