Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to 1.22.7 #582

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Bump go version to 1.22.7 #582

merged 1 commit into from
Dec 2, 2024

Conversation

avorima
Copy link
Contributor

@avorima avorima commented Nov 29, 2024

What this PR does / why we need it:

Increase the minimum go version to 1.22.7 which includes some CVE fixes.

For context: we are building images with the github release binary and our image scanner picks up the CVEs.

Signed-off-by: Mario Valderrama <[email protected]>
Copy link
Member

@porridge porridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's time for me to finally read up on the semantics of these directives. It seems strange that having a stale version here would prevent someone from building with a more recent toolchain 🤯

@porridge porridge added the dependencies Pull requests that update a dependency file label Dec 2, 2024
@porridge porridge merged commit 12f8b11 into kudobuilder:main Dec 2, 2024
6 checks passed
@avorima avorima deleted the update-go branch December 2, 2024 08:36
@avorima
Copy link
Contributor Author

avorima commented Dec 2, 2024

Depends on how the binaries are built. Our workflows configure the setup-go action to read the exact version from the go.mod, but the version and toolchain are always a minimum requirement. I don't know how kuttl release binaries are built, so this PR might've been redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants