send-dfi bot to fix immature UTXOs issue
#101
Conversation
mrgrauel
changed the title
mrgrauel
changed the title
|
Changed it to draft, because I have an idea which I'd like to try, but if you want please give me initial feedback. |
IdeaI have multiple Vault Maxis, but I want to push a specific maxi in the next couple of days / weeks / months. So I'd like to push all rewards to a specific address. I'll rename the bot to |
mrgrauel
changed the title
send-dfi Bot to fix immature UTXO issue
mrgrauel
changed the title
send-dfi Bot to fix immature UTXO issuesend-dfi bot to fix immature UTXOs issue
ocean-client/src/utils/store.ts
Outdated
| @@ -60,6 +61,8 @@ export class StoredSettings { | |||
| mainCollateralAsset: string = 'DFI' | |||
| stableCoinArbBatchSize: number = -1 | |||
| reinvestThreshold: number | undefined | |||
| sendThreshold: number | undefined | |||
| sendAll: boolean = false | |||
There was a problem hiding this comment.
probably time to refactor this, so that every program-store has its own stored settings. right now this is becoming a mix of all of them.
| const accountToUtxos: AccountToUtxos = { | ||
| from: this.script!, | ||
| balances: [{ token: 0, amount: fromBalance }], | ||
| mintingOutputsStart: 2, | ||
| } | ||
|
|
||
| const txn = await account?.withTransactionBuilder()?.account.accountToUtxos(accountToUtxos, this.script!) | ||
| if (txn === undefined) { | ||
| await telegram.send('ERROR: transactionSegWit is undefined') | ||
| console.error('transactionSegWit is undefinedd') | ||
| return false | ||
| } |
There was a problem hiding this comment.
building tx normally happens in common-program. There you can use the already proven ways to build defiTx. then you also don't need to make this.script protected.
| const decodedToAddress = fromAddress(this.toAddress, this.walletSetup.network.name) | ||
| if (decodedToAddress === undefined) { | ||
| console.error('decodedFromAddress is undefined') | ||
| await telegram.send('ERROR: decodedFromAddress is undefined') | ||
| return false | ||
| } | ||
| let txn: TransactionSegWit | undefined | ||
| if (this.sendAll) { | ||
| txn = await account?.withTransactionBuilder()?.utxo.sendAll(decodedToAddress.script) | ||
| } else { | ||
| txn = await account?.withTransactionBuilder()?.utxo.send(amountToUse, decodedToAddress.script, this.script!) | ||
| } | ||
|
|
||
| if (txn === undefined) { | ||
| await telegram.send('ERROR: transactionSegWit is undefined') | ||
| console.error('transactionSegWit is undefinedd') | ||
| return false | ||
| } |
There was a problem hiding this comment.
again, this would be better in common program. then it can be reused by other programs when they want to send UTXOs
| if (this.sendAll) { | ||
| txn = await account?.withTransactionBuilder()?.utxo.sendAll(decodedToAddress.script) | ||
| } else { | ||
| txn = await account?.withTransactionBuilder()?.utxo.send(amountToUse, decodedToAddress.script, this.script!) | ||
| } |
There was a problem hiding this comment.
both case are effectivly "send amountToUse" right? why have it seperated here?
| return false | ||
| } | ||
|
|
||
| if (!(await this.sendAndWait(txn, telegram))) { |
There was a problem hiding this comment.
if you use it as prevout, you don't need to wait and can add the sendUTXO tx right away. -> only need to wait onces at the end.
@mrgrauel does sendall something different than combining all UTXOs? I think send-all won't work with immature UTXOs either, right? |
|
It doesn't work either, it's just an easy way to guarantee that everything is send. I'll try to use |
|
@kuegi using common-program build defi tx works for all OP_DEFI_TXs but sending UTXOs is not an OP_DEFI_TX. Thats why I have said to @mrgrauel that it will be easier to make two transactions with transaction builder instead of refactoring common-program that both raw-txs are working. Esp. if somebody is just starting with jellyfish it is hard to write raw-txs right from the start. Yes this can and should be improved, but i don't know if this PR is the right place to do so |
agreed on the send of utxo, but the account to utxo should move to common. I anyway need those two for the new reinvest feature. will add them in there, then it can be used here too. |
It's a workaround bot for #100.
It looks for DFI (and UTXO) which it tries to send to
toAddress.Another possibility use case is moving funds from a maxi to any other wallet, like a reinvest to DFX Staking or another Maxi etc.
Build
Setup
Add following paramters to the AWS Parameter Store
defichain-maxi/wallet-send/toAddressdefichain-maxi/wallet-send/fromAddressOptional you can add:
defichain-maxi/settings-send/threshold(Default: 1)defichain-maxi/settings-send/sendall(Default: false)