Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] 記事ページの中央カラムの幅を広げたい #1405

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oti
Copy link
Contributor

@oti oti commented Nov 26, 2024

課題・背景

記事ページの中央カラムの幅が minmax(auto, 712px) で狭いので広くしたい。

#1206 と同じ内容ですが、あちらはAstro化する前のPRで古いので新しく立て直しました。

やったこと

  • .main の article カラムの幅を 712px から 2fr に広げた

やらなかったこと

動作確認

キャプチャ

Before After
スクリーンショット 2024-11-26 14 46 27 スクリーンショット 2024-11-26 14 46 33
スクリーンショット 2024-11-26 14 56 14 スクリーンショット 2024-11-26 14 56 37

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit cee169b
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/67626909a61bfc000845e544
😎 Deploy Preview https://deploy-preview-1405--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oti
Copy link
Contributor Author

oti commented Nov 26, 2024

こういうのってレビュワーは誰にしたらいいのだろう

Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants