Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextLink]新規ウィンドウで開くときとヘルプページを開くときが同時のときを対処を記載 #1432

Merged
merged 7 commits into from
Dec 25, 2024
Merged

[TextLink]新規ウィンドウで開くときとヘルプページを開くときが同時のときを対処を記載 #1432

merged 7 commits into from
Dec 25, 2024
+8 −2

Conversation

oremega
Copy link
Contributor

@oremega oremega commented Dec 11, 2024 •
edited
Loading

課題・背景

やったこと

  • 「新規ウィンドウで開くテキストリンク」が必須であることを明記・強調
  • 「ヘルプセンターを開くテキストリンク」が推奨であることを強調
  • 新規ウィンドウとヘルプセンターが同時のときには新規ウィンドウを優先することを明記

やらなかったこと

動作確認

キャプチャ

Before After

@netlify Netlify
Copy link

netlify bot commented Dec 11, 2024 •
edited
Loading

✅ Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit 4e282c7
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/675c03373123db0008edd3bb
😎 Deploy Preview https://deploy-preview-1432--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oremega oremega marked this pull request as ready for review December 12, 2024 08:50
@oremega oremega requested a review from a team as a code owner December 12, 2024 08:50
versionfive
versionfive reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@versionfive versionfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしましたー

src/content/articles/products/components/text-link/index.mdx Outdated Show resolved Hide resolved
src/content/articles/products/components/text-link/index.mdx Outdated Show resolved Hide resolved
src/content/articles/products/components/text-link/index.mdx Outdated Show resolved Hide resolved
src/content/articles/products/components/text-link/index.mdx Outdated Show resolved Hide resolved
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

❌ Deploy Preview for dancing-dusk-8c613c failed.

Name Link
🔨 Latest commit 49943a4
🔍 Latest deploy log https://app.netlify.com/sites/dancing-dusk-8c613c/deploys/675beba8f664b400087b1c4a

@oremega oremega requested a review from versionfive December 13, 2024 09:55
tosiiu
tosiiu approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@tosiiu tosiiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oremega oremega merged commit ab847c4 into main Dec 25, 2024
5 checks passed
@oremega oremega deleted the update_text-link branch December 25, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tosiiu tosiiu tosiiu approved these changes

@MasafumiKabe MasafumiKabe Awaiting requested review from MasafumiKabe MasafumiKabe is a code owner automatically assigned from kufu/product-designer

@uknmr uknmr Awaiting requested review from uknmr

@versionfive versionfive Awaiting requested review from versionfive

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oremega @tosiiu @versionfive