Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ダイアログのmax-heightにpaddingの考慮がない問題を修正 #4682

Closed
wants to merge 2 commits into from
Closed

fix: ダイアログのmax-heightにpaddingの考慮がない問題を修正 #4682

wants to merge 2 commits into from

Conversation

misako0927
Copy link
Contributor

Related URL

Overview

What I did

Capture

uknmr
uknmr reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultHtmlFontSize を持ってきて自前で計算せず、padding に実際にあたる値と同じになるよう useTailwindTheme から spacing を呼び出すのがよさそうに思いました。

const { spacing } = useTheme()
const offsetPadding = spacing(paddingBlock)

maxHeight: `calc(100svh - ${offsetHeight}px - (${offsetPadding} * 2))`

@misako0927
Copy link
Contributor Author

別チケットで巻き取ることになったのでclose

@misako0927 misako0927 closed this Aug 14, 2024
@uknmr uknmr deleted the add-padding-to-max-height branch August 14, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uknmr uknmr uknmr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misako0927 @uknmr