Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TabBar): TabItemの高さ固定をpaddingの積み上げに修正 #4683

Closed
wants to merge 3 commits into from

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented May 30, 2024

Related URL

https://smarthr.atlassian.net/browse/SHRUI-923

Overview

TabItemの高さ固定を廃止し、paddingの積み上げで表現するように修正

What I did

  • TabItem内の高さ指定を削除し、paddingの積み上げに修正
  • Figmaを正とし、TabBar自体の高さが40pxになるように調整
    • 現行だとなぜか43pxあった

Capture

@uknmr
Copy link
Collaborator

uknmr commented May 30, 2024

Figma や現状のコードを正とせず、マジックナンバーを減らしつつ積み上げで正を作れるとよさそうに思いました。

@Qs-F
Copy link
Contributor Author

Qs-F commented Jul 24, 2024

Dup of #4804, closed.

@Qs-F Qs-F closed this Jul 24, 2024
@uknmr uknmr deleted the fix/tabbar/remove-absolute-height-tabitem@923 branch July 24, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants