Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Balloon): Safariで影の表示が崩れるバグを修正 #4697

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Jun 5, 2024

Related URL

https://kufuinc.slack.com/archives/CGC58MW01/p1717565094192419

Overview

SafariでBalloonの影が残り続けたり、表示されなかったりするバグを修正

What I did

  • will-change: filter 相当のCSSをBalloonに追加

Capture

Before After
image image

SafariでStorybookを開いてタブで移動したりマウスでフォーカスしたりをテキトウにすると確認できると思います

@Qs-F
Copy link
Contributor Author

Qs-F commented Jun 5, 2024

なんかめちゃめちゃVRTで差分が発生してる…?

rerunめっちゃしたら解決しました 謎… :saikidouha_subetewo_kaiketsusuru:

https://kufuinc.slack.com/archives/CGC58MW01/p1717567762105319

@Qs-F Qs-F marked this pull request as ready for review June 5, 2024 07:35
@Qs-F Qs-F requested a review from a team as a code owner June 5, 2024 07:35
@Qs-F Qs-F requested review from yt-ymmt and moshisora and removed request for a team June 5, 2024 07:35
Copy link
Member

@Tokky0425 Tokky0425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 🌮

@Tokky0425 Tokky0425 merged commit ffd29a8 into master Jun 5, 2024
8 checks passed
@Tokky0425 Tokky0425 deleted the fix/ballooon/shadow-remaining-on-safari branch June 5, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants