feat!: ErrorScreen の footer props を omit する
#4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oti
requested review from
s-sasaki-0529 and
uknmr
and removed request for
a team
| @@ -24,7 +24,7 @@ type Props = { | |||
| }> | |||
| /** 表示するコンテンツ */ | |||
| children?: ReactNode | |||
| /** フッター */ | |||
| /** @deprecated フッター指定は非推奨です。リンクの表示が必要な場合は links を使用してください。 */ | |||
There was a problem hiding this comment.
使われていないのなら非推奨化じゃなくて即削除しちゃっても良いかなと思いましたがどうでしょう？
逆に、残すのであれば非推奨であろうと Storybook で確認できてほしい気がしました。
s-sasaki-0529
approved these changes
Jun 11, 2024
uknmr
requested changes
Jun 12, 2024
|
@s-sasaki-0529 @uknmr |
oti
changed the title
footer props を deprecated にするfooter props を omit する
s-sasaki-0529
approved these changes
Jun 13, 2024
uknmr
changed the title
footer props を omit するfooter props を omit する
uknmr
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
Overview
footerprops を消したいfullの意味がわかりにくい（おそらく props 全部指定？）のでallに変更したいwithout children/with footerの Storybook をトルツメしたいWhat I did
footerprops を消したfullの意味がわかりにくい（おそらく props 全部指定？）のでallに変更したwithout children/with footerの Storybook をトルツメしたallの内容が実装例に寄りすぎていたので無味無臭なものにしたCapture