Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: MultiCombobox の VRT はフレーキーな問題を修正する #4721

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

s-sasaki-0529
Copy link
Contributor

Related URL

N/A

Overview

MultiCombobox の VRT で発生する、以下のようなフレーキーな結果が生じないようにする
https://www.chromatic.com/test?appId=63d0ccabb5d2dd29825524ab&id=666b8d48fab7ae85ed175fce

What I did

Play 関数にてコンボボックスを操作した直後で、カーソルが点滅状態になっているため、撮影されるスクリーンショットにブレが生じてしまっていた。

操作後にテキストボックスからフォーカスを外すことでこれを修正する。

@s-sasaki-0529 s-sasaki-0529 self-assigned this Jun 14, 2024
@s-sasaki-0529 s-sasaki-0529 marked this pull request as ready for review June 14, 2024 12:14
@s-sasaki-0529 s-sasaki-0529 requested a review from a team as a code owner June 14, 2024 12:14
@s-sasaki-0529 s-sasaki-0529 requested review from oti and AtsushiM and removed request for a team June 14, 2024 12:14
Copy link
Contributor

@oti oti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uknmr uknmr merged commit 01f25ff into master Jun 25, 2024
8 checks passed
@uknmr uknmr deleted the fix-flaky-vrt-0614 branch June 25, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants