chore: code 要素の表示がVRTでフレーキーになる問題を解消する #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9536044.
s-sasaki-0529
requested review from
AtsushiM and
masa0527
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
Overview
Storybook 内で
<code>タグを使用した箇所について、フォント (monospace) が VRT結果ごとにブレてフレーキーになってしまう問題を解消したい。この問題は毎ビルドランダムに発生するため、高頻度で差分扱いされてしまい、開発(特に単発のコントリビューター) に混乱を及ぼしている。
What I did
原因を調査し、Chromatic 社に問い合わせたりもしたが、原因特定には至らなかった(詳細はチケット参照)
Chromatic 社からの助言も参考に、Code タグに対するフォントをジェネリックの monospace から、別のフォントを明示するようにした。
動作確認
フォントを変更したので初回は差分多数なのですべて Accept.
そこから何度か Chromatic 再実行を促し、いずれもTrubosnap 不使用で差分なし判定が出ることを確認。
普段の頻度を考えるとこれだけ連続成功してるなら大丈夫そう…？