fix: DropdownMenuButtonで矢印キーを押してフォーカスを移動できる #4902
Merged
+109
−101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzzCokeK
commented
Sep 10, 2024
Comment on lines
3
to
12
| const matchesDisabledState = (element: Element): boolean => | ||
| element.matches(':disabled') || element.getAttribute('aria-disabled') === 'true' | ||
|
|
||
| const isElementDisabled = (element: Element): boolean => { | ||
| if (matchesDisabledState(element)) return true | ||
| if (Array.from(element.querySelectorAll('*')).some((child) => matchesDisabledState(child))) | ||
| return true | ||
|
|
||
| return false | ||
| } |
There was a problem hiding this comment.
判定周りを関数として切り出しています
atzzCokeK
requested review from
yt-ymmt and
masa0527
and removed request for
a team
yt-ymmt
approved these changes
Sep 10, 2024
packages/smarthr-ui/src/components/Dropdown/DropdownMenuButton/useKeyboardNavigation.ts
Outdated
Show resolved
Hide resolved
…/useKeyboardNavigation.ts Co-authored-by: Yuta Yamamoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
Slack
概要
変更内容
確認方法
2024-09-10.11.04.11.mov