Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "feat!: Combobox の inputAttributes を消し、input に直接渡すように修正" #4909

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Sep 11, 2024

#4907 への fix をする際、変更が大きくなりすぎないように Reverts #4842

@uknmr uknmr requested a review from a team as a code owner September 11, 2024 05:27
@uknmr uknmr requested review from AtsushiM and masa0527 and removed request for a team September 11, 2024 05:27
Copy link
Member

@AtsushiM AtsushiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uknmr uknmr changed the title Revert "feat!: Combobox の inputAttributes を消し、input に直接渡すように修正" revert: "feat!: Combobox の inputAttributes を消し、input に直接渡すように修正" Sep 11, 2024
@uknmr uknmr changed the title revert: "feat!: Combobox の inputAttributes を消し、input に直接渡すように修正" chore: Revert "feat!: Combobox の inputAttributes を消し、input に直接渡すように修正" Sep 11, 2024
@uknmr uknmr enabled auto-merge (squash) September 11, 2024 05:33
@uknmr uknmr merged commit e5976a0 into master Sep 11, 2024
8 of 10 checks passed
@uknmr uknmr deleted the revert-4842-fix-Combobox-id branch September 11, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants