Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FormControlのlabel自動紐づけが不要な場合の対応を追加 #4918

Merged
merged 9 commits into from
Sep 19, 2024
Merged

fix: FormControlのlabel自動紐づけが不要な場合の対応を追加 #4918

merged 9 commits into from
Sep 19, 2024

Conversation

AtsushiM
Copy link
Member

@AtsushiM AtsushiM commented Sep 13, 2024 •
edited
Loading

関連URL

概要

  • FormControlで紐づけるべき入力要素が既にidなどを持っている場合、不要な処理を実行しないように修正します

変更内容

  • FormControlで紐づけるべき入力要素が既にidなどを持っている場合、不要な処理を実行しないよう修正
  • aria-describedby の紐づけ方をlabelと紐づける際の処理を共通化
  • その他軽微な修正

確認方法

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 13, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@4918

commit: 249f499

@AtsushiM AtsushiM changed the title fix: FormControl内に対象IDの要素が存在する場合の判定を追加 fix: FormControlのlabel自動紐づけが不要な場合の対応を追加 Sep 13, 2024
@AtsushiM AtsushiM marked this pull request as ready for review September 13, 2024 01:30
@AtsushiM AtsushiM requested a review from a team as a code owner September 13, 2024 01:30
@AtsushiM AtsushiM requested review from moshisora and nabeliwo and removed request for a team September 13, 2024 01:30
@AtsushiM AtsushiM requested a review from uknmr September 17, 2024 02:58
uknmr
uknmr approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fieldset の Story で挙動に問題ないことを確認しました。

packages/smarthr-ui/src/components/FormControl/FormControl.tsx Show resolved Hide resolved
@AtsushiM AtsushiM merged commit 2c17a17 into master Sep 19, 2024
10 checks passed
@AtsushiM AtsushiM deleted the fix-form-control branch September 19, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uknmr uknmr uknmr approved these changes

@moshisora moshisora Awaiting requested review from moshisora moshisora is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@nabeliwo nabeliwo Awaiting requested review from nabeliwo nabeliwo is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AtsushiM @uknmr