Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table コンポーネントの使われていない記述を削除 #4921

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

nabeliwo
Copy link
Member

@nabeliwo nabeliwo commented Sep 15, 2024

関連URL

なし

概要

Table コンポーネントに使用されていないコードが残っていたので削除したい

変更内容

  • createContext でコンテキストを作っていた処理を削除
    • 以前使っていた名残の消し忘れっぽい
    • これがなくなると、Table コンポーネントが Server Component から使用できるようになります
      • Th がまだ Server Component から使えないのでこの PR 単体だとあんまり意味ないけど…

確認方法

Story で Table が以前同様動いていれば ok

@nabeliwo nabeliwo requested a review from a team as a code owner September 15, 2024 06:29
@nabeliwo nabeliwo requested review from misako0927 and uknmr and removed request for a team September 15, 2024 06:29
@nabeliwo nabeliwo changed the title fix: Table コンポーネントの使われていない 記述を削除 fix: Table コンポーネントの使われていない記述を削除 Sep 15, 2024
Copy link

pkg-pr-new bot commented Sep 15, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@4921

commit: 74f2017

Copy link
Member

@AtsushiM AtsushiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uknmr uknmr merged commit fe3e56f into kufu:master Sep 17, 2024
12 checks passed
@nabeliwo nabeliwo deleted the fix-table branch September 17, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants