-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FormControlのエラー表示設定方法を変更し、より確実に設定されるように修正する #4925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
fix-form-control-error-attributes
branch
2 times, most recently
from
September 17, 2024 02:54
df11112
to
7deeb8c
Compare
yagimushi
force-pushed
the
fix-form-control-error-attributes
branch
from
September 17, 2024 23:11
7deeb8c
to
c402dbd
Compare
commit: |
AtsushiM
changed the title
Fix form control error attributes
feat: FormControlのエラー表示設定方法を変更し、より確実に設定されるように修正する
Sep 18, 2024
yagimushi
force-pushed
the
fix-form-control-error-attributes
branch
from
September 19, 2024 05:39
ffbd058
to
5d5135c
Compare
…form-control-error-attributes
AtsushiM
requested review from
Qs-F and
masa0527
and removed request for
a team
September 19, 2024 05:47
PR本文を埋めていただけるとレビューしやすくて助かりますー |
内容関係ないしまだ見てないんですが、レビュー前はガンガン rebase した方がレビューしやすいように思いました。 |
これが見たいならFiles Changed見れば良いのでrebaseする意味があまりないような? |
masa0527
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
問題ないと思います!
プロダクト側で発生していた紐づけがうまくいかなかった部分もこちらの修正で解消されてました 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法