Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(SideMenu): SideMenuGroupを使用しないサンプルを追加 #4947

Merged
merged 1 commit into from
Sep 26, 2024
Merged

docs(SideMenu): SideMenuGroupを使用しないサンプルを追加 #4947

merged 1 commit into from
Sep 26, 2024

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Sep 24, 2024 •
edited
Loading

関連URL

https://kufuinc.slack.com/archives/CDG1XRPTP/p1727146089496589?thread_ts=1726813803.339369&cid=CDG1XRPTP

概要

  • SideMenuのStorybookにSideMenuGroupを使わない例を追加した

変更内容

  • SideMenuのStorybookにSideMenuGroupを使わない例を追加した
    • Default にSideMenuGroupを使わないシンプルなものを設置
    • 今までのものを Grouped に改名

確認方法

https://63d0ccabb5d2dd29825524ab-ymnkzwtxnh.chromatic.com/?path=/docs/experimental%EF%BC%88%E5%AE%9F%E9%A8%93%E7%9A%84%EF%BC%89-sidemenu--docs

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 24, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@4947

commit: 9faabba

@Qs-F Qs-F marked this pull request as ready for review September 24, 2024 06:27
@Qs-F Qs-F requested a review from a team as a code owner September 24, 2024 06:27
@Qs-F Qs-F requested review from moshisora and nabeliwo and removed request for a team September 24, 2024 06:27
uknmr
uknmr approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gogo

@uknmr uknmr merged commit 90e8bf2 into master Sep 26, 2024
11 checks passed
@uknmr uknmr deleted the docs/sidemenu/add-simple-not-grouped-story branch September 26, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uknmr uknmr uknmr approved these changes

@moshisora moshisora Awaiting requested review from moshisora moshisora is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@nabeliwo nabeliwo Awaiting requested review from nabeliwo nabeliwo is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qs-F @uknmr