fix(smarthr-ui-preset): breakpointを設定 #4965
Draft
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://kufuinc.slack.com/archives/C013KCVC0P3/p1727686839153149
強い気持ちがある人が現れると修正内容がかわるかも https://kufuinc.slack.com/archives/CGC58MW01/p1727691651343259
概要
smarthr-ui-presetに対してbreakpointの設定を行った
変更内容
createBreakpoint
と同じ値を設定min-width
で設定されるが、SmartHRではデスクトップを先に作ってからモバイル対応という流れが多いため、SP:shr-hogehoge
でモバイル用のスタイルをあてられる方が利点が高いと考えmax-width
で追加確認方法
例えばButton.tsxのwrapperに
SP:shr-bg-[red]
を追加し、ブラウザの幅を縮めると背景色が赤くなることを確認2024-09-30.19.05.47.mov