chore: eslintのignore commentを削除 or 不要なように調整する #4986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
AtsushiM
commented
Oct 8, 2024
Comment on lines
+48
to
+51
|
|
||
| if (onFormatValue) { | ||
| onFormatValue(formatted) | ||
| } |
There was a problem hiding this comment.
今回の修正とは本質的に関係がないのですが、何故かコメント削除するとエラーが発生するようになったため、厳密な書き方に修正しています
There was a problem hiding this comment.
この件ですねー。実害はないので良さそう。
https://kufuinc.slack.com/archives/CGC58MW01/p1728349717774749
AtsushiM
commented
Oct 8, 2024
| @@ -145,18 +145,12 @@ export const Demo: StoryFn = () => { | |||
| )} | |||
| <StyledWrapper> | |||
| <Stack> | |||
| {/* eslint-disable-next-line jsx-a11y/label-has-associated-control */} | |||
| <label> | |||
There was a problem hiding this comment.
CheckBoxは内部でlabelを持っており、label in label になっていたため削除しています。
マークアップ構造が変わっていますが、storybookのため、ユーザー影響はありません
| @@ -173,5 +172,7 @@ export const Input = forwardRef<HTMLInputElement, Props & ElementProps>( | |||
|
|
|||
| const disableWheel = (e: WheelEvent) => { | |||
| // wheel イベントに preventDefault はないため | |||
| e.target && (e.target as HTMLInputElement).blur() | |||
| if (e.target) { | |||
| ;(e.target as HTMLInputElement).blur() | |||
There was a problem hiding this comment.
[nits]
このセミコロンは流石に無くても大丈夫そう
There was a problem hiding this comment.
なんかformatで自動追加されたんですよね〜
まぁこのまま行きますね
s-sasaki-0529
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法