chore: Badge の Story を見直し #4988
Merged
+136
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
s-sasaki-0529
commented
Oct 8, 2024
|
|
||
| export default { | ||
| title: 'States（状態）/Badge/VRT', | ||
| /* ペアワイズ法は使わずにすべての組み合わせを網羅する */ |
There was a problem hiding this comment.
ペアワイズ法をゴニョゴニョして色々試しはしたんですけど、このコンポーネントならペアワイズ使うまでもなく全描画パターン洗い出せるなと気づいたので使わなかったです。
というのもありですかね？ Button みたいに全網羅は不可能な組み合わせ爆発が起こる場合のみ pict を導入するみたいな。
There was a problem hiding this comment.
ありだと思います! pict の運用はそれなりに手間がかかりそうなので、必要な時だけで良さそうですね。
s-sasaki-0529
requested review from
AtsushiM and
atzzCokeK
and removed request for
a team
uknmr
approved these changes
Oct 8, 2024
|
|
||
| export default { | ||
| title: 'States（状態）/Badge/VRT', | ||
| /* ペアワイズ法は使わずにすべての組み合わせを網羅する */ |
There was a problem hiding this comment.
ありだと思います! pict の運用はそれなりに手間がかかりそうなので、必要な時だけで良さそうですね。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1151
概要
#4949 の方針に沿って、Badge コンポーネントの Story を見直しました。
もう少し小さめのコンポーネントで流れを掴んでから、デカ目のコンポーネントに手を出していきます。
変更内容
確認方法
Storybook や Chromatic で確認してください。