-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Textarea): 最大文字数を超えたエラーを色以外でも表現する #5084
Merged
daiHash
merged 7 commits into
master
from
SHRUI-1074-show-more-explicit-error-in-textarea
Dec 18, 2024
+95
−25
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3a43219
fix: 最大文字数メッセージの内容とスクリーンリーダーで通知する修正
daiHash 4922f06
fix: 不要なコードの削除
daiHash c0e7cd7
fix: 不要のstory削除
daiHash 6ae25f5
fix: 文言修正
daiHash 25903ea
fix: useIdをprefixとして再利用する
daiHash 22ba73e
fix: スクリーンリーダーの補足メッセージのdecorator対応
daiHash 3377ec6
fix: コメント修正
daiHash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
スクリーンリーダー読み上げようのメッセージは1秒くらい遅延しています。input入力で更新すると、連続更新された場合にスクリーンリーダーで古いカウントでも読み上げてしまう場合がりました
例えば
messageの文言をさん文字くらい消すと、最大文字数が10文字であれば、
あと4文字
=>あと5文字
=>あと6文字
でよみあげてしまうばあいがありますため、クリーンリーダー通知メッセージ更新を遅延してます