feat: WarekiPicker を追加 #5196
Merged
feat: WarekiPicker を追加 #5196
+238
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uknmr
requested review from
yt-ymmt and
nabeliwo
and removed request for
a team
uknmr
force-pushed
the
add-WarekiPicker
branch
from
47dce7d to
dc5464c
Compare
uknmr
force-pushed
the
add-WarekiPicker
branch
from
dc5464c to
43afe74
Compare
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1000
概要
DatePicker を和暦に特化させた WarekiPicker を追加しました（厳密に言えば Wareki を pick するわけではない）。
合わせて DatePicker / DateTimeLocalPicker / MonthPicker / TimePicker などを非推奨とし、
<Input type="{date | datetime-local | month | time" />を使うように促します。変更内容
showAlternativeで和暦を表示するコンポーネントを WarekiPicker として追加確認方法
Storybook や Chromatic で確認してください。