fix(Th): ソートアイコンが左寄せになっていたのを修正 #5205
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uknmr
requested review from
oti,
Qs-F and
mterada1228
and removed request for
a team
commit: |
uknmr
commented
Dec 18, 2024
| variants: { | ||
| align: { | ||
| left: 'shr-justify-between', | ||
| left: '', |
There was a problem hiding this comment.
https://github.com/kufu/smarthr-ui/pull/5144/files#diff-aa8eeac36839797f4a810812b300666314b452f674eed732f5891df9e05deaa0L18 で align の初期値を tailwind-variants 側に寄せたことによる影響が sortButton 側にも出ていました。
デフォルト（left）で shr-justify-between、right の時に shr-justify-end で上書き、という形に修正。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
#5144 で紛れ込んでしまった不具合を修正します。ソート付き Th のアイコンが両端揃えではなく左に依ってしまっていました。
変更内容
両端揃えになるように調整。
確認方法
Storybook や Chromatic で確認してください。