Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(FormDialog): 構造をシンプル化 #5213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(FormDialog): 構造をシンプル化 #5213

wants to merge 1 commit into from
+8 −14

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Dec 18, 2024

関連URL

#5192 (comment)

概要

#5192 で変更された構造をシンプル化しActionDialogに近づけた

変更内容

  • form を display: contents で囲うことでレイアウトが崩れてしまう問題を回避

確認方法

@Qs-F Qs-F marked this pull request as ready for review December 18, 2024 12:17
@Qs-F Qs-F requested a review from a team as a code owner December 18, 2024 12:17
@Qs-F Qs-F requested review from misako0927 and s-sasaki-0529 and removed request for a team December 18, 2024 12:17
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 18, 2024

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5213

commit: 3bf3348

@Qs-F
Copy link
Contributor Author

Qs-F commented Dec 18, 2024

アクセシビリティレビュー待ちです: https://kufuinc.slack.com/archives/C06L25PMFMG/p1734524355153989

uknmr
uknmr approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@uknmr uknmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
実装的には最高!
Storybook とコードを確認しました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uknmr uknmr uknmr approved these changes

@misako0927 misako0927 Awaiting requested review from misako0927 misako0927 is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

@s-sasaki-0529 s-sasaki-0529 Awaiting requested review from s-sasaki-0529 s-sasaki-0529 is a code owner automatically assigned from kufu/group-dev-smarthr-ui-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qs-F @uknmr