fix: pnpm publish時にブランチを指定 #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibulog
force-pushed
the
fix/pnpm-publish-option
branch
from
a7a62c5 to
e9d4334
Compare
ibulog
force-pushed
the
fix/pnpm-publish-option
branch
from
e9d4334 to
0b90dc4
Compare
|
|
|
@alpaca-tc こういうフローになっている理由としては、リリースタグを作成してnpm publishする間にmainブランチへのマージが行われる可能性があることを考慮しているのかな...？と推察しています |
|
であれば、publish-branchにrelease-candidateを指定するのが期待するオプションであるように思います。ドキュメント読んだだけで未検証ですが… |
|
なるほど、確かに |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題・背景
GitHub Actionsでpnpm publishを実行する際、--no-git-checksを指定しないと、npmへの公開に失敗するpublishするブランチがmain/master以外の場合は指定しないといけないpnpm publishを実行する際、ブランチを明示しないとエラーが発生するやったこと
pnpm publishに--publish-branch release-candidateを追加