-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Mike Beaumont <[email protected]>
- Loading branch information
1 parent
ee4590f
commit 9128ab9
Showing
2 changed files
with
28 additions
and
0 deletions.
There are no files selected for viewing
27 changes: 27 additions & 0 deletions
27
patches/v1.31-0001-dns-don-t-error-if-header-id-is-0.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
From db432303b88ef5197ad6ed330a15173bf7967e1d Mon Sep 17 00:00:00 2001 | ||
From: Mike Beaumont <[email protected]> | ||
Date: Tue, 9 Jul 2024 10:14:29 +0200 | ||
Subject: [PATCH] dns: don't error if header id is 0 | ||
|
||
--- | ||
source/extensions/filters/udp/dns_filter/dns_parser.cc | 4 ---- | ||
1 file changed, 4 deletions(-) | ||
|
||
diff --git a/source/extensions/filters/udp/dns_filter/dns_parser.cc b/source/extensions/filters/udp/dns_filter/dns_parser.cc | ||
index b63f69278d..9be5917d9b 100644 | ||
--- a/source/extensions/filters/udp/dns_filter/dns_parser.cc | ||
+++ b/source/extensions/filters/udp/dns_filter/dns_parser.cc | ||
@@ -212,10 +212,6 @@ bool DnsMessageParser::parseDnsObject(DnsQueryContextPtr& context, | ||
} | ||
|
||
context->id_ = static_cast<uint16_t>(context->header_.id); | ||
- if (context->id_ == 0) { | ||
- ENVOY_LOG(debug, "No ID in DNS query"); | ||
- return false; | ||
- } | ||
|
||
// Almost always, we will have only one query here. Per the RFC, QDCOUNT is usually 1 | ||
context->queries_.reserve(context->header_.questions); | ||
-- | ||
2.45.2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters