Use glob to match *.route files #453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why CI is failing. I'm using yarn 1.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes use glob to mount routes (i.e. auth.route.js and user.route.js).
1 main question:
In these changes I use the first part of the name as the url. As a result I had to rename user.route.js to userS.route.js so the route stayed the same--I also renamed the other user files as well to be consistent. Do you have any thoughts on this?
BTW, thank you for this example. I have a bunch of APIs I wrote that I'm planning to open source soon, so I'm re-writing them to be consistent with the structure you have here. I really like the organization and readability. Thanks!
If you have any comments on style or organization please let me know.