Event types v2 and resilience for cameras going offline #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # src/dahua.ts # src/index.ts
…ycling after electricity down events. Parse camera index to number early as string would sometimes get newline characters messing up with logs. Update logging to understand current state of connection to camera/NVR without spam to HB logs.
anton-iermolenko
changed the title
anton-iermolenko
changed the title
|
Hi there, thanks for the contribution. Can you please reduce scope on this PR? At minimum this should be split in into several changes:
|
|
Ok. Created pull request for motion event types support only. Lets figure it out first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15
Fixes #42
Support for different camera events types, i.e video blind/loss, smart motion events. Resilience working with cameras/NVR that lose power/go offline often.