Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update measure model for localization #385

Merged
merged 19 commits into from
Feb 14, 2025
Merged

feat: update measure model for localization #385

merged 19 commits into from
Feb 14, 2025

Conversation

cyrng
Copy link
Contributor

@cyrng cyrng commented Nov 29, 2024 •
edited
Loading

What does this PR do ?

This PR is related to the iot-platform PR.

It add locales for asset model and implement an endpoint to update all assets related to this asset model.

Ticket

How should this be manually tested?

  • Step 1 : Add a locales in an asset model
  • Step 2 : Create an asset from this asset model
  • Step 3 : Check if the locales is in the document
  • Step 4 : Update the asset model
  • Step 5 : Send a PATCH request to the endpoint device-manager/assets/modelLocales
  • Step 6 : Check the changing in all assets from the asset model

Other changes

Boyscout

@etrousset etrousset added the 2.6 label Dec 4, 2024
@cyrng cyrng self-assigned this Jan 8, 2025
Base automatically changed from 2-dev to beta January 22, 2025 13:56
Base automatically changed from beta to master January 22, 2025 15:32
@cyrng cyrng marked this pull request as ready for review January 23, 2025 15:20
@cyrng cyrng changed the base branch from master to 2-dev January 23, 2025 15:23
@cyrng cyrng force-pushed the KZLPRD-689-etq-utilisateur-jvp-definir-et-internationaliser-les-nomes-des-modeles-de-mesure-et-dassets branch from 3aa2afd to e889636 Compare January 23, 2025 16:07
etrousset
etrousset requested changes Jan 27, 2025
View reviewed changes
@cyrng cyrng force-pushed the KZLPRD-689-etq-utilisateur-jvp-definir-et-internationaliser-les-nomes-des-modeles-de-mesure-et-dassets branch from a47e890 to 394fba8 Compare February 10, 2025 15:17
etrousset
etrousset requested changes Feb 11, 2025
View reviewed changes
etrousset
etrousset requested changes Feb 11, 2025
View reviewed changes
Copy link
Member

@etrousset etrousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more feedback

@etrousset etrousset removed the 2.6 label Feb 12, 2025
etrousset
etrousset requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@etrousset etrousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make sure to return a proper status code accordingly to the result of updateByQuery:
200 ok,
206

@etrousset etrousset merged commit 429678f into 2-dev Feb 14, 2025
11 checks passed
@etrousset etrousset deleted the KZLPRD-689-etq-utilisateur-jvp-definir-et-internationaliser-les-nomes-des-modeles-de-mesure-et-dassets branch February 14, 2025 09:10
github-actions bot pushed a commit that referenced this pull request Feb 14, 2025
@semantic-release-bot
chore(release): 2.8.0-dev.4 [skip ci]
e8777cd 
## [2.8.0-dev.4](v2.8.0-dev.3...v2.8.0-dev.4) (2025-02-14)

### Features

* update measure model for localization ([#385](#385)) ([429678f](429678f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrousset etrousset etrousset approved these changes

@afondard afondard Awaiting requested review from afondard

@QuentinRousselet QuentinRousselet Awaiting requested review from QuentinRousselet

@thomas-mauran thomas-mauran Awaiting requested review from thomas-mauran

Assignees

@cyrng cyrng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyrng @etrousset