refactored for integration with alembic #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked location of some function calls to support multple purposes Added migration calls to be manually added into alembic migrations
added 6 commits
December 19, 2019 12:28
Session related features are not under SessionManager There is a BaseVersioningManager for use with Alembic VersioningManager and FlaskVersioningManager remain api compatible
jpollard-cs
reviewed
Jul 8, 2020
| """ | ||
| for cls in self.pending_classes: | ||
| self.audit_table(cls.__table__, cls.__versioned__.get('exclude')) | ||
| assign_actor(self.base, self.transaction_cls, self.actor_cls) |
There was a problem hiding this comment.
is this assign_actor call redundant or does this listener overwrite the one from the base after_configured method?
|
Here's a forked and modified version of this package for anyone that needs alembic/flask-sqlalchemy integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked location of some function calls to support multple purposes
Added migration calls to be manually added into alembic migrations