Adds typescript types #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @ajmath thanks for the suggestion.. but I not so understand on how it works 😢 (no TS experience) |
|
That's all fine, it's mergeable as is now. Just something to consider for the future if you start adding some CI. |
|
Much needed PR, otherwise I have to jump to GitHub readme everytime to see the type of value a property expects |
|
@kyaroru do you want to merge this? |
cenksari
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're interested in adding some validation for the types, I can help set that up but it would require adding
react,react-native, andtypescriptas dev dependencies which I didn't want to do since there are none currently. Basically, add those dependencies and then add an npm script withnpx tsc --noEmit ./index.d.ts.